[Core] Check that temp_dir must be absolute path. #36431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do you have a suggested place to place the test? |
cadedaniel
reviewed
Jun 14, 2023
rynewang
changed the title
|
force-pushed because the test commit did not have signed-off-by. |
jjyao
approved these changes
Jun 15, 2023
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
cadedaniel
approved these changes
Jun 16, 2023
|
Looks like the test failures are not related to my change. @jjyao would you mind taking a look and merge? |
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
ray.init accepts a _temp_dir arg. The arg should be absolute path because it makes no sense to have a "relative path" on all nodes. However the code did not check that and proceeds as if it is absolute path. This makes the init code to hang and timeout. Example issues for treating it as absolute: the latest_session symlink links to the temp_dir and if it is relative path it won't work. Signed-off-by: Ruiyang Wang <rywang014@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ray.initaccepts a_temp_dirarg. The arg should be absolute path because it makes no sense to have a "relative path" on all nodes. However the code did not check that and proceeds as if it is absolute path. This makes the init code to hang and timeout.Example issues for treating it as absolute: the
latest_sessionsymlink links to the temp_dir and if it is relative path it won't work.Compatibility Analysis
The call
ray.init()times out when the arg is relative path, so it never worked and now we forbid it. This won't break any existing usage.Related issue number
Closes #30650.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.